Repository navigation
Conversation
Author
|
The issue was originally filed in joelcapitao/bib-fcos-experimentation#166 |
Member
|
cc @jbtrystram / @joelcapitao as I seem to recall either of you working on this or at least mentioning it before? |
Member
|
Ah I see @jbtrystram already commented on this in the linked issue. |
Author
|
@supakeen thanks for approving the PR! |
Member
I've triggered them. |
The grub2.d stage mounts the image filesystems but has no bind mount connecting them to the pipeline tree. Writing console.cfg through tree:// therefore leaves the file outside the generated disk image. Change the destination to mount://boot/grub2/console.cfg and update the expected paths in the serialization tests.
Roshan-R
force-pushed
the
fix/grub-mount
branch
from
November 13, 2026 13:40
cbccfaa to
a2dcdd5
Compare
Author
|
@supakeen I had to rebase the branch to merge and it looks like we have to run CI again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The grub2.d stage mounts the image filesystems but has no bind mount
connecting them to the pipeline tree. Writing console.cfg through
tree:// therefore leaves the file outside the generated disk image.
Change the destination to mount://boot/grub2/console.cfg and update
the expected paths in the serialization tests.